Move screenrecording state files out of predictable /tmp paths

[gauravbhatia4601]

Fixes #8372

Problem

RECORDING_FILE was pinned to a fixed /tmp path, and the debug LOG_FILE as well. In a world-writable directory any local user can pre-create or truncate those paths between the writing and the reading, since the same path is reused across runs.

When the recording user stops a recording, stop_screenrecording reads that file and feeds its content into finalize_recording, which drives ffmpeg -y -i , mv, and rm -f based on the stored path. A planted path can therefore redirect those operations at files owned by the recording user. The fixed /tmp debug log is the same family of issue: a local user can pre-create or truncate it, and the recording process appends to whatever that path points at.

Fix

Move both files to the same uid-scoped location REGION_FILE already uses in this script and omarchy-update-stay-awake uses elsewhere:

• RECORDING_FILE -> ${XDG_RUNTIME_DIR:-/tmp}/omarchy-screenrecord-filename
• LOG_FILE -> ${XDG_RUNTIME_DIR:-/tmp}/omarchy-screenrecord.log

XDG_RUNTIME_DIR is user-private (mode 0700, owned by the user), so a local attacker can no longer pre-create or truncate these paths. REGION_FILE in the same script already used exactly this pattern, so this makes the three state files consistent.

Also updated the two docs that referenced the fixed /tmp log path (default/agents/skills/omarchy/capture.md and contributing.md).

Testing

• bash -n clean on the modified script
• test/shell.d/screenrecording-test.sh passes (18/18 assertions)
• test/shell.d/logging-test.sh passes
• ./test/cli passes
• Full ./test/shell run: 2571 assertions pass; the 19 failing files on this headless container are pre-existing environmental failures (missing lua, fonts, compositor) and fail identically on an unpatched checkout of the same commit.

[gauravbhatia4601]

Friendly review ping when someone gets a chance — this closes #8372 (screenrecording state files moved to the uid-scoped XDG_RUNTIME_DIR pattern REGION_FILE already uses in the same script). Tests: screenrecording-test.sh 18/18, logging-test.sh, ./test/cli all pass; docs updated to match the new paths.

[omarchybot]

quattro already fixes this. #8374 merged on 2026-09-15 as b44fb74 and closed #8372, the issue this pull request fixes.

Both make the same change for the same reason: they move RECORDING_FILE and the debug LOG_FILE in bin/omarchy-capture-screenrecording from fixed /tmp names into the per-user runtime directory, and update the log path in capture.md and contributing.md. On top of that, #8374 falls back to ${XDG_STATE_HOME:-$HOME/.local/state}/omarchy when XDG_RUNTIME_DIR is unset, instead of /tmp, which this branch keeps as the fallback. It also resolves the region file the same way in omarchy-capture-webcam-resize. This branch adds nothing quattro lacks, and it no longer merges cleanly because quattro rewrote the same lines. The recommendation is to close it as a duplicate of #8374.

Checked by Claude Opus 5.5, by reading both diffs against quattro. Nothing was run, because the change is already on quattro. No second opinion ran: the reviewer (Codex Medium) has used up today's review allowance, and closing a duplicate requires one. So this is left open for the maintainer to close rather than closed here.

[omarchybot]

Thank you for this, @gauravbhatia4601. Closing because #8374 already fixes this on quattro.

Closed at the maintainer's request. The review comment above has the details; it was done by Claude Opus 5.5 with Codex Medium as a second opinion, whose agreement is not independent.