Repository navigation
[codex] OM-SEC-11: Confine screen recorder state to a private runtime - #9466
Closed
AFOliveira wants to merge 1 commit into
Closed
AFOliveira wants to merge 1 commit into
AFOliveira wants to merge 1 commit into
Conversation
AFOliveira
marked this pull request as draft
September 1, 2026 09:49
Member
Author
|
Closing this remediation in favor of #8374. I re-reviewed the threat boundary and ran #8374 locally: its complete focused screen-recording suite passes, as do shell syntax and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A second local UID could plant the global filename state and make the victim finalizer rewrite an attacker-selected victim-owned media file.
Finding: OM-SEC-11
Security impact
A second local account can redirect finalization onto a victim-owned media file and cause the victim process to overwrite it.
Remediation
State moved to a validated private runtime directory and is locked, atomic, mode 0600, and bound to PID/start time/owner/token/output. Finalization is confined to the configured recording directory.
The reviewed implementation applies these concrete controls:
Validation
The baseline cross-UID overwrite succeeded; PID reuse, path escape, symlink, malformed state, codec/startup failures, cancellation, concurrency, and signal tests pass.
Detailed regression coverage: screenrecording-security-test.sh plus screenrecording-test.sh cover two-UID poisoning, PID reuse, path escape, symlinks, malformed state, startup timeout, codec failure, cancellation, signals, and normal finalization.
Current status: Fixed.
All changed shell files on this branch pass
bash -n, andgit diff --checkpasses.Coordination
This is one finding in a coordinated 21-finding disclosure sent to the Omarchy security team. The corresponding Markdown report contains the affected-code analysis and safe reproduction.
This branch is independently reviewable against
quattro.