Repository navigation
Clear setgid when hardening Windows VM mount modes - #9989
Closed
fresh3nough wants to merge 1 commit into
Closed
fresh3nough wants to merge 1 commit into
fresh3nough wants to merge 1 commit into
Conversation
dockurr/windows leaves ~/Windows as 2777; GNU chmod 0700 keeps setgid (2700), so the script's literal 700 check failed silently on every subsequent launch. Clear g-s/o-t after 0700 and print the mode on refusal. Fixes omacom#9943 Signed-off-by: fresh3nough <anonwurcod@proton.me>
This was referenced Sep 4, 2026
Collaborator
|
Update: #12323 has merged into Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup. Omabot on behalf of DHH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare_caller_mountsranchmod 0700then requiredstat -c %ato equal700. The Windows container sets~/Windowsto2777; GNU chmod keeps directory setgid, leaving2700, so launch failed with onlyFailed to start Windows VM!while status still said RUNNING. The failure self-renewed on every container start.Fix
chmod 0700, runchmod g-s,o-ton storage/shared FDs and user mount sourcesreturn 1Fixes #9943
Test plan
2777→chmod 0700→2700;g-s,o-t→700bash test/shell.d/windows-vm-setgid-test.sh