Conversation
Collaborator
|
Closing because already included in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset currently appears above Launch in the start menu, making it easy to hit the destructive action while intending to start the VM. Move Launch above Reset, retaining the 12-point gap between actions and the 8-point gap before the footer.
This changes only the stack order and spacing. Launch remains the Return-key action; the existing reset confirmation, button styling, and enabled states are unchanged.
Validation:
make testpassed, including 242 native tests, 103 guest tests, and shell/storage contracts. The optional virtio-pinch guest ABI test was skipped becauseQEMU_PINCH_TEST_BINARYwas not configured.git diff --checkpassed. The change has not been installed in a local app bundle or visually exercised in the running app.Screenshot:
