ci: restructure release workflows to unblock PyPI trusted publishing#234
Draft
MikeGoldsmith wants to merge 2 commits into
Draft
ci: restructure release workflows to unblock PyPI trusted publishing#234MikeGoldsmith wants to merge 2 commits into
MikeGoldsmith wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases fail at
pypa/gh-action-pypi-publishbecause it runs from a reusable workflow, which PyPI trusted publishing doesn't support (warehouse#11096).This PR moves the publish step into a job defined directly in each top-level release workflow. The rest of the release logic stays DRY via two reusable workflows (
_release-build.yml,_release-finalize.yml). Prepare workflows are renamed and consolidated at the same time.Follow-up (not in this PR): register two new trusted publishers per PyPI project (
release-package.ymlandrelease-all.yml, environmentpypi). See the updatedRELEASING.mdtable.