add http.{request,response}.body.content#3521
Conversation
… into http-request-response-body
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
@trask can you re-open this ? Should we create a dedicated SIG/project to handle that ? |
… into http-request-response-body
|
Update: updating to cover request + response (as suggested here) and also making it client+server. |
SylvainJuge
changed the title
AlexanderWert
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
… into http-request-response-body
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
… into http-request-response-body
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
… into http-request-response-body
… into http-request-response-body
| The maximum captured body size must be limited by the `AttributeValueLengthLimit` configuration option defined in the | ||
| [OpenTelemetry SDK specification](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/README.md#configurable-parameters). | ||
|
|
||
| To prevent excessive overhead and storage by default, instrumentations MUST issue a warning when the feature is used without an explicit `AttributeValueLengthLimit` configuration option. |
There was a problem hiding this comment.
instrumentation has no knowledge of configuration applied by the application.
I'd propose to just remove this paragraph
There was a problem hiding this comment.
From what I understand this means that without access to the SDK configuration, we have no way to issue a warning when the feature is used without limit (which is something we may want to avoid).
Do you think it would make sense to add the following requirement for feature implementation documentation ?
Enabling this feature is likely to capture large values and thus the feature documentation MUST recommend to set an explicit value for
AttributeValueLengthLimitto avoid excessive overhead ?
| The maximum captured body size must be limited by the `AttributeValueLengthLimit` configuration option defined in the | ||
| [OpenTelemetry SDK specification](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/README.md#configurable-parameters). |
There was a problem hiding this comment.
This is not actionable for instrumentation authors - let's remove ?
Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
… into http-request-response-body
5 participants
Part of #857
http.{request,response}.body.contentattribute as typeany.Covers both the request and response, however the implementation is likely to focus on the server request first: