[chore] Switch to gh releases for weaver version#3829
Open
thompson-tomo wants to merge 2 commits into
Open
Conversation
lmolkova
reviewed
Jun 29, 2026
| depNameTemplate: "otel/weaver", | ||
| datasourceTemplate: "docker", | ||
| depNameTemplate: "open-telemetry/weaver", | ||
| datasourceTemplate: "github-releases", |
Member
There was a problem hiding this comment.
was this tested? weaver is used in makefiles through docker, version numbers might be inconsistent between GH and docker
Contributor
Author
There was a problem hiding this comment.
yes i have tested that it is detecting updates. I am aware of how it is used, however this custom manager is responsible for only updating the vscode setting for the schema hence no impact on the docker image used by makefile.
This change has been tested end to end in other repo and it doesn't produce the error like we are seeing with the current solution.
kamphaus
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This switches to sourcing the weaver version from gh releases as opposed to docker hub. This switch is to address the error shown in the renovate dashboard #2101 due to not being able to pin it.
This is a transfer of what is working in the ruby contrib repo to keep semconv version up to date.
Important
Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.
Merge requirement checklist
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩