Skip to content

[chore] Switch to gh releases for weaver version#3829

Open
thompson-tomo wants to merge 2 commits into
open-telemetry:mainfrom
thompson-tomo:patch-1
Open

[chore] Switch to gh releases for weaver version#3829
thompson-tomo wants to merge 2 commits into
open-telemetry:mainfrom
thompson-tomo:patch-1

Conversation

@thompson-tomo

@thompson-tomo thompson-tomo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Changes

This switches to sourcing the weaver version from gh releases as opposed to docker hub. This switch is to address the error shown in the renovate dashboard #2101 due to not being able to pin it.

image

This is a transfer of what is working in the ruby contrib repo to keep semconv version up to date.

Important

Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Links to prototypes or existing instrumentations (when adding or changing conventions)
  • Disclose AI usage, see OTel GenAI policy:
    • no AI used
    • AI-assisted
    • bulk AI-generated
  • I have the experience and knowledge necessary to understand, review, and validate all content in this PR.1

Footnotes

  1. Yes, I can answer maintainer questions about the content of this PR without using AI.

@thompson-tomo thompson-tomo changed the title Switch to gh releases for weaver version [chore] Switch to gh releases for weaver version Jun 26, 2026
Comment thread .github/renovate.json5
depNameTemplate: "otel/weaver",
datasourceTemplate: "docker",
depNameTemplate: "open-telemetry/weaver",
datasourceTemplate: "github-releases",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this tested? weaver is used in makefiles through docker, version numbers might be inconsistent between GH and docker

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i have tested that it is detecting updates. I am aware of how it is used, however this custom manager is responsible for only updating the vscode setting for the schema hence no impact on the docker image used by makefile.

This change has been tested end to end in other repo and it doesn't produce the error like we are seeing with the current solution.

@kamphaus kamphaus moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs More Approval

Development

Successfully merging this pull request may close these issues.

3 participants