Conversation
…712) Widens field_prgf_image (paragraph:banner) target_bundles from image-only to image/video/video_local, mirroring lb_hero's field_media which already supports the same three bundles on the same entity_reference-to-media pattern. Updates the media_library_widget's media_types to match, and adds update_10003 so existing sites (which never re-import config/install) pick this up on the next deploy. Companion change: openy_carnation's paragraph--banner.html.twig currently only renders an image background. Rendering support for the new media types is in a separate MR since that's a different project: https://git.drupalcode.org/project/openy_carnation/-/merge_requests/126 small_banner has the identical image-only field but is intentionally left untouched here pending confirmation it's in scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
field_prgf_image(paragraph:banner)target_bundlesfrom image-only toimage/video/video_local, mirroringlb_hero'sfield_mediawhich already supports the same three bundles on the same entity_reference-to-media pattern.media_library_widget'smedia_typesto match.openy_prgf_banner_update_10003()so existing sites (which never re-importconfig/install) pick this up on the next deploy.Companion change
Rendering support (actually showing the video as a background instead of the image) is
openy_carnationtheme territory — separate project, separate MR: https://git.drupalcode.org/project/openy_carnation/-/merge_requests/126. This PR alone just makes the field able to reference video media; without the theme MR the video option shows in the media library but doesn't render as a background yet.Scope note
small_bannerparagraph has the identical image-onlyfield_prgf_imagelimitation, intentionally left untouched here pending confirmation it should get the same treatment.Test plan
openy_prgf_banner_update_10003()tested against a site with the old image-only config; runs clean and produces the same end state as a fresh install