Verbraucher in HV einrechnen einstellbar - #3939
Merged
Merged
Conversation
LKuemmel
requested review from
AlexanderHa98
and
a balanced review from Copilot
September 14, 2026 13:28
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The standalone configuration topic is rejected by the MQTT write handler, and migration coverage is missing.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds configurable home-consumption handling for consumers.
Changes:
- Adds consumer mode configuration and migration.
- Includes consumer power based on inherited or explicit mode.
- Adds calculation tests.
File summaries
| File | Description |
|---|---|
packages/helpermodules/update_config.py |
Migrates consumer configuration to datastore version 146. |
packages/control/counter_all/counter_home_consumption_test.py |
Tests consumer mode calculations. |
packages/control/counter_all/counter_all.py |
Incorporates consumers into home consumption. |
packages/control/consumer/consumer_data.py |
Defines the consumer mode setting. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+67
to
+68
| is_home_consumption_consumer: str = field( | ||
| default="auto_home_consumption", metadata={"topic": "config/is_home_consumption_consumer"}) |
| ) | ||
| self._append_datastore_version(145) | ||
|
|
||
| def upgrade_datastore_146(self) -> None: |
AlexanderHa98
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openWB/openwb-ui-settings#1090