fix: leftover pv_charging topic paths from PR #3812 topic migration - #3941
Open
seaspotter wants to merge 1 commit into
Open
fix: leftover pv_charging topic paths from PR #3812 topic migration#3941seaspotter wants to merge 1 commit into
seaspotter wants to merge 1 commit into
Conversation
…tion processAllMqttMsg.js: standard_legacy's message dispatcher still only matched the old chargemode_config/pv_charging/ prefix, so the retained bat_mode message never reached processPvConfigMessages() after it moved to chargemode_config/bat/mode - the Überschussverwendung radio buttons never showed the persisted selection on page load (only after manually clicking one, via a separate local handler). ParameterHandler.php: setBatPowerReserve() was left publishing to the old pv_charging/bat_power_reserve topic, which setdata.py no longer validates - the endpoint reported success without actually changing the reserve (same migration Copilot already flagged for bat_mode on PR openWB#3812, but missed for bat_power_reserve).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix leftover topics from #3812
Fix: #3908 (comment)