fix(parser): accept shorthand LLVM byte types - #1356
Merged
Merged
Conversation
sueszli
force-pushed
the
fix/llvm-nested-byte-type
branch
2 times, most recently
from
September 7, 2026 11:32
c44889f to
1ba401b
Compare
math-fehr
approved these changes
Sep 17, 2026
math-fehr
left a comment
math-fehr
left a comment
Collaborator
There was a problem hiding this comment.
I missed this sorry, but all good, just fix the merge commits and we can merge it!
sueszli
force-pushed
the
fix/llvm-nested-byte-type
branch
from
September 17, 2026 08:51
1ba401b to
3b49240
Compare
Contributor
Author
|
Awesome, yeah, i just rebased :) |
Collaborator
|
Nice. Let me merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #952.
MLIR introduced
!llvm.byte<N>in llvm/llvm-project@e559d43. ItsPrettyLLVMTypedispatch accepts barebyte<N>, and!llvm.arrayuses that directive for its element type.byteis omitted from the issue checklist.This makes:
equivalent to
!llvm.array<2 x !llvm.byte<8>>.