feat(puddle): add denotational validity - #1470
Merged
Merged
Conversation
Collaborator
|
CI failure: ... i guess this is still WIP - I wait until this is marked ready-for-review .. |
Collaborator
Author
|
Yes, I am fixing the tactic a bit (not the final version of the tactic, but at least something that works) before marking this ready. I shouldn't have requested review on a draft PR though. |
math-fehr
force-pushed
the
math-fehr/puddle-validity
branch
from
September 15, 2026 14:52
02e366e to
0f7a147
Compare
math-fehr
marked this pull request as ready for review
September 15, 2026 14:52
Collaborator
Author
|
Should be good now |
math-fehr
force-pushed
the
math-fehr/puddle-validity
branch
from
September 16, 2026 15:03
0f7a147 to
deccd03
Compare
Collaborator
Author
|
@tobiasgrosser gentle ping on this, it should be ready for review now |
tobiasgrosser
approved these changes
Sep 18, 2026
ineol
approved these changes
Sep 18, 2026
ineol
left a comment
Collaborator
There was a problem hiding this comment.
Really cool! only minor naming comments
ineol
reviewed
Sep 18, 2026
math-fehr
force-pushed
the
math-fehr/puddle-validity
branch
from
September 18, 2026 13:28
deccd03 to
86cdd32
Compare
math-fehr
force-pushed
the
math-fehr/puddle-validity
branch
from
September 18, 2026 13:57
86cdd32 to
8e1fe7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds
Pattern.PreservesSemantics, a proposition that asserts that a puddle pattern is semantically valid. With this, we can prove (in a separate PR) that once the pattern is compiled, it satisfiesLocalRewritePattern.PreservesSemantics.This change also creates
simpPuddleSemantics, a simplification tactic to remove all thePreservesSemanticsdefinitions, so the only has a clean goal to prove.