feat(PBV): Convert multiplication of masks into shifts of popcounts. - #1565
Merged
Merged
Conversation
Collaborator
|
Nice. Luigi, can you add the perf improvements into the commit message. Also, tag Luisa when this is ready to review. I am sure she is curious about this change. |
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-perf
branch
2 times, most recently
from
September 28, 2026 16:40
12ba99a to
9eec291
Compare
Contributor
Author
will do, I ran into some grind bug I had to work around. |
luigirinaldi
marked this pull request as ready for review
September 28, 2026 16:41
Contributor
Author
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-perf
branch
from
September 28, 2026 16:43
9eec291 to
5f3691f
Compare
naveen-seth
reviewed
Sep 28, 2026
naveen-seth
left a comment
naveen-seth
left a comment
Contributor
There was a problem hiding this comment.
Cool! When this has landed, I'll see if #1524 could work with a 64 bit bound!
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-perf
branch
from
September 29, 2026 16:24
5f3691f to
f722931
Compare
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-perf
branch
from
September 29, 2026 16:26
f722931 to
e5d0fde
Compare
luisacicolini
approved these changes
Sep 29, 2026
luisacicolini
left a comment
luisacicolini
left a comment
Contributor
There was a problem hiding this comment.
lgtm (only reviewed style)
naveen-seth
approved these changes
Sep 30, 2026
Co-authored-by: Tobias Christian Grosser <tobias@grosser.es>
luigirinaldi
force-pushed
the
luigirinaldi/bpbv-perf
branch
from
September 30, 2026 09:10
fb2c696 to
b76481e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change push theorem of
appendand the theorem relating additions of masks, to shift instead of multiplying masks. The value of the width can be retrieved from its mask by computing thepopcountof the mask, which is a much more efficient circuit for bit-blasting.add_widening_genericproofs for 64 bits goes from 4.5s → 539ms (8.4×) and from timing out at 128-bits to 1.2s. Similar speed ups on the examples inBoundedBitblastingcontaining append operations.While implementing this, ran into a bug in
grind, so had to update how masks of literals are stated. This also meant some of the code for pretty counterexample printing became redundant.