Skip to content

perf(registry): use weak ETag in express adapter #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardo-devis-agullo wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −1
Open

perf(registry): use weak ETag in express adapter #1565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44fae5d
perf(registry): use weak ETag in express adapter
ricardo-devis-agullo Sep 6, 2026
c301770
test(registry): lock in weak ETag default in express adapter
ricardo-devis-agullo Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/oc/src/registry/domain/http-server/express-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ class ExpressHttpServerAdapter
this.app.set('port', port);
}
this.app.set('json spaces', 0);
this.app.set('etag', 'strong');
// Weak ETag (Express default): keeps conditional-request support with
// W/ prefix and weak comparison; no consumer relies on strong ETags.
this.app.set('etag', 'weak');
}

enableBodyParser(opts: { limit?: number | string }): void {
Expand Down
6 changes: 6 additions & 0 deletions packages/oc/test/unit/registry-domain-http-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,10 @@ describe('registry : domain : http-server : express-adapter', () => {
});
});
});

it('uses weak ETags (Express default)', () => {
const adapter = createAdapter();

expect(adapter.native().get('etag')).to.equal('weak');
});
});
Loading