Repository navigation
Stop raising exceptions for optional discovery fields - #983
Merged
Merged
Conversation
w-goog
force-pushed
the
codegen/rfc8414-optional-metadata-a
branch
from
October 21, 2026 22:03
64bc32c to
c1f51bd
Compare
…ional-metadata-a # Conflicts: # CHANGELOG.md
brnnmrls
reviewed
Oct 27, 2026
brnnmrls
reviewed
Oct 27, 2026
brnnmrls
reviewed
Oct 27, 2026
brnnmrls
reviewed
Oct 27, 2026
brnnmrls
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first half of fixing #380.
OIDServiceDiscoverynow check for a string before parsing, so a sloppy optional URL (unparseable,null, not a string) just reads asnil.issuer,authorization_endpoint,token_endpoint,jwks_uri). They have to be present and parse, and a JSONnullfails withOIDErrorCodeInvalidDiscoveryDocumentinstead of raising an exception. Anauthorization_endpointthat doesn't parse now fails the document too, like the other required URL fields.pendingTest...cases!! plus three for the sloppy-optional cases.RFC 8414 documents that omit
jwks_uri& co. still fail validation. The right fix is to mark those propertiesnullable, but that'd be source-breaking, so we'll do that in the 4.0 release.Note for reviewers: I narrowed the URL check, since a provider's sloppy
op_tos_urishouldn't block a sign-in. Only the nonnull URL fields are validated. The nullable getters already returnednilfor a bad URL, and now do the same fornullor a non-string.