Fix and test handling of partially-read objects - #69
Open
twiss wants to merge 1 commit into
Open
Conversation
In `slice`, `transform[Async]` and `readToEnd`, properly handle (non-)stream objects that were partially read (e.g. peeked at) before. Also, add tests of the various cases.
twiss
force-pushed
the
handle-partially-read-objects
branch
from
November 6, 2025 16:13
0cab127 to
6519b87
Compare
larabr
force-pushed
the
main
branch
2 times, most recently
from
November 13, 2025 13:10
d0f6ef9 to
d8efe87
Compare
larabr
reviewed
Sep 3, 2026
| ArrayStream.prototype.readToEnd = async function(join) { | ||
| await this[doneWritingPromise]; | ||
| const result = join(this.slice(this[readingIndex])); | ||
| const result = join((this[externalBuffer] || []).concat(this.slice(this[readingIndex]))); |
Collaborator
There was a problem hiding this comment.
The stale externalBuffer content is returned on repeated readToEnd calls I think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
slice,transform[Async]andreadToEnd, properly handle (non-)stream objects that were partially read (e.g. peeked at) before.Also, add tests of the various cases.