Skip to content

feat(helm): set GAR image defaults in controller chart values - #79

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-online:mainfrom
jimdaga:feat/helm-gar-image-defaults
Aug 11, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-online:mainfrom
jimdaga:feat/helm-gar-image-defaults

Conversation

@jimdaga

@jimdaga jimdaga commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What

Set default image.registry and image.repository in all 5 gecko controller Helm charts to point to the Konflux-published GAR image:

image:
  registry: us-docker.pkg.dev
  repository: gcp-hcp-commons/gcp-hcp-images/gecko-controllers

Previously these were CHANGE_ME placeholders that required the ArgoCD Application templates to override them.

Charts updated

  • gecko-hc
  • gecko-nodepool
  • gecko-nodepool-vr-resolution
  • gecko-placement
  • gecko-version-resolution

Also updated _helpers.tpl validation error messages to reference the correct GAR path.

Why

Moves the image source of truth into the Helm charts (next to the code that produces it) instead of the infra repo's ArgoCD templates. This reduces duplication and makes the ArgoCD templates simpler — they only need to override image.tag.

Companion PR

openshift-online/gcp-hcp-infra#1164 removes the now-redundant image.registry and image.repository overrides from the ArgoCD Application templates.

Merge order: This PR should merge first, then the infra PR. If the infra PR merges first, ArgoCD will temporarily use the CHANGE_ME defaults and fail to deploy.

Set default image.registry and image.repository in all 5 gecko controller
Helm charts to point to the Konflux-published GAR image:

  us-docker.pkg.dev/gcp-hcp-commons/gcp-hcp-images/gecko-controllers

This allows the ArgoCD Application templates to stop overriding these
values and only set image.tag.

Companion PR: openshift-online/gcp-hcp-infra#1164
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 11, 2026
@jimdaga

jimdaga commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@jimdaga
jimdaga marked this pull request as ready for review August 11, 2026 19:56
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2026
@openshift-ci
openshift-ci Bot requested review from patjlm and thetechnick August 11, 2026 19:56
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jimdaga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit b4563af into openshift-online:main Aug 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants