Repository navigation
feat(helm): set GAR image defaults in controller chart values - #79
Merged
openshift-merge-bot[bot] merged 1 commit intoAug 11, 2026
Conversation
Set default image.registry and image.repository in all 5 gecko controller Helm charts to point to the Konflux-published GAR image: us-docker.pkg.dev/gcp-hcp-commons/gcp-hcp-images/gecko-controllers This allows the ArgoCD Application templates to stop overriding these values and only set image.tag. Companion PR: openshift-online/gcp-hcp-infra#1164
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test all |
jimdaga
marked this pull request as ready for review
August 11, 2026 19:56
cblecker
approved these changes
Aug 11, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, jimdaga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Aug 11, 2026
b4563af
into
openshift-online:main
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set default
image.registryandimage.repositoryin all 5 gecko controller Helm charts to point to the Konflux-published GAR image:Previously these were
CHANGE_MEplaceholders that required the ArgoCD Application templates to override them.Charts updated
gecko-hcgecko-nodepoolgecko-nodepool-vr-resolutiongecko-placementgecko-version-resolutionAlso updated
_helpers.tplvalidation error messages to reference the correct GAR path.Why
Moves the image source of truth into the Helm charts (next to the code that produces it) instead of the infra repo's ArgoCD templates. This reduces duplication and makes the ArgoCD templates simpler — they only need to override
image.tag.Companion PR
openshift-online/gcp-hcp-infra#1164 removes the now-redundant
image.registryandimage.repositoryoverrides from the ArgoCD Application templates.