Skip to content

Update dependency @patternfly/react-core to v6.6.1 - autoclosed #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
red-hat-konflux wants to merge 1 commit into from
Closed

Update dependency @patternfly/react-core to v6.6.1 - autoclosed #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gateway-management-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"shiki": "4.4.1"
},
"peerDependencies": {
"@patternfly/react-core": "6.6.0",
"@patternfly/react-core": "6.6.1",

@jsell-rh jsell-rh Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] Version split within this file. This peerDependencies entry is now @patternfly/react-core: 6.6.1, but the devDependencies entry (line 36) still pins 6.6.0, so the package is built/tested against 6.6.0 while declaring it needs 6.6.1 from consumers. Bump the devDependency in the same change so both match. Also note the sole consumer components/web-console/package.json:34 still provides 6.6.0, which no longer satisfies this exact peer pin. Consider landing together with #189 (react-icons 6.6.1) and a react-table bump to keep the PatternFly family in lockstep.

@jsell-rh jsell-rh Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Critical] Exact peer pin unsatisfiable under strict peer resolution.

This raises the @patternfly/react-core peerDependency to an exact 6.6.1, but the same file still declares devDependencies["@patternfly/react-core"] = 6.6.0 (L36) and the only consumer, components/web-console/package.json, pins 6.6.0 (L34). With strictPeerDependencies: true and saveExact: true, a version-mismatched peer is treated as invalid and will fail pnpm install/check, not just warn.

Fix: bump the devDependency here (L36) and the web-console dependency (L34) to 6.6.1 in the same change, and align react-icons/react-table so the PatternFly family stays on one version.

@jsell-rh jsell-rh Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] Peer floor now diverges from what is built/tested. This bumps the peerDependencies entry to 6.6.1, but the package's own devDependencies entry for @patternfly/react-core (line 36) stays at 6.6.0, and the actual consumer components/web-console/package.json still pins 6.6.0. So the new peer floor (6.6.1) is neither exercised by this package's build/test toolchain nor satisfied by the in-repo consumer. strict-peer-dependencies is not enabled, so this is a peer warning rather than a CI failure, but consider bumping the devDependency (and, if intended, the consumer) to 6.6.1 so the declared contract matches what is compiled and tested.

@amber-review-bot amber-review-bot Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] pnpm-lock.yaml was not regenerated for this bump. The lockfile still records specifier: 6.6.0 for @patternfly/react-core in this package's importer, and 6.6.1 of react-core is not present in the lockfile at all. Because CI installs with pnpm install --frozen-lockfile (checks.yml, unit-tests.yml, e2e.yml, Makefile), this mismatch will fail with ERR_PNPM_OUTDATED_LOCKFILE. Run pnpm install --lockfile-only and commit pnpm-lock.yaml.

[Minor] devDependencies.@patternfly/react-core (line 36) is still 6.6.0; it is the devDependency that is actually installed to build/test this package, so it should move to 6.6.1 alongside the peer requirement.

"@patternfly/react-icons": "6.6.0",
"@patternfly/react-table": "6.6.0",
"@tanstack/react-query": "5.101.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/operational-dashboard-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"peerDependencies": {
"@openshift-online/hypershell-domain-probes": "workspace:0.0.0",
"@patternfly/react-charts": "8.6.1",
"@patternfly/react-core": "6.6.0",
"@patternfly/react-core": "6.6.1",

@amber-review-bot amber-review-bot Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] Same lockfile issue as the sibling package: pnpm-lock.yaml still pins @patternfly/react-core at 6.6.0 for this importer, so pnpm install --frozen-lockfile in CI will fail. Regenerate and commit the lockfile.

[Minor] devDependencies.@patternfly/react-core (line 41) remains 6.6.0 while this peer entry is now 6.6.1; align them.

"@patternfly/react-icons": "6.6.0",
"@patternfly/widgetized-dashboard": "1.0.0-prerelease.6",
"@tanstack/react-query": "5.101.4",
Expand Down
Loading