Skip to content

Update dependency @patternfly/react-table to v6.6.1 - autoclosed #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
red-hat-konflux wants to merge 1 commit into from
Closed

Update dependency @patternfly/react-table to v6.6.1 - autoclosed #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gateway-management-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"peerDependencies": {
"@patternfly/react-core": "6.6.0",
"@patternfly/react-icons": "6.6.0",
"@patternfly/react-table": "6.6.0",
"@patternfly/react-table": "6.6.1",

@jsell-rh jsell-rh Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer requirement is raised to 6.6.1 here, but devDependencies (line 38) and pnpm-lock.yaml still pin/resolve 6.6.0. So the package keeps building and testing against 6.6.0 while telling consumers to install 6.6.1 — the update is not actually exercised until the dev dependency and lockfile advance too. Also note react-table@6.6.1 expects its @patternfly/react-core/react-icons siblings (lines 24-25) at the same version; keeping them on 6.6.0 leaves the PatternFly family out of lockstep.

@jsell-rh jsell-rh Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raises the peer requirement to exactly 6.6.1, but nothing that actually provides @patternfly/react-table moves with it: this package's devDependencies (line 38), the components/web-console consumer, and pnpm-lock.yaml all still resolve 6.6.0. Result: the 6.6.1 contract is untested and currently unsatisfied by the consumer. Also, react-core/react-icons remain 6.6.0 (lines 24-25); the PatternFly react-* family should move in lockstep. Bump the devDependency + consumer + lockfile and land the family together.

@amber-review-bot amber-review-bot Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This peer bump raises @patternfly/react-table to 6.6.1, but the devDependencies entry (line 38) and pnpm-lock.yaml still resolve 6.6.0, so the package is built and tested against 6.6.0 while advertising an exact 6.6.1 peer requirement. This is the expected result of the repo Renovate config splitting peer vs dev updates (no peerDependencies packageRule), so a companion dev-dependency bump should follow to align the tested version and regenerate the lockfile. Also note the sibling @patternfly/react-core/react-icons peers here remain at 6.6.0 - keep the PatternFly family on one version when these land.

"@tanstack/react-query": "5.101.4",
"react": "19.2.8",
"react-dom": "19.2.8",
Expand Down
Loading