Skip to content

Add platform-gcp cluster profile, Boskos quota, and secret bootstrap#82102

Draft
jimdaga wants to merge 2 commits into
openshift:mainfrom
jimdaga:feature/GCP-554-cluster-profile-boskos
Draft

Add platform-gcp cluster profile, Boskos quota, and secret bootstrap#82102
jimdaga wants to merge 2 commits into
openshift:mainfrom
jimdaga:feature/GCP-554-cluster-profile-boskos

Conversation

@jimdaga

@jimdaga jimdaga commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Registers the platform-gcp cluster profile for gcp-hcp-infra E2E testing:

  • Cluster profile (cluster-profiles-config.yaml): platform-gcp, restricted to openshift-online/gcp-hcp-infra
  • Boskos (generate-boskos.py + regenerated _boskos.yaml): platform-gcp-quota-slice with 3 concurrent slots
  • Secret bootstrap (_config.yaml): seed cluster-secrets-platform-gcp with pull-secret dockerconfigJSON

Vault secret

Self-service secret already created at selfservice/gcp-hcp-platform-ci/credentials with:

  • secretsync/target-namespace: ci
  • secretsync/target-name: cluster-secrets-platform-gcp
  • wif-config.json: WIF credential config for keyless GCP auth
  • ci-folder-id: Platform CI folder ID
  • billing-account-id: billing account for test project linking

Profile details

Field Value
name platform-gcp
cluster_type platform-gcp
lease_type platform-gcp-quota-slice
secret cluster-secrets-platform-gcp
owners openshift-online/gcp-hcp-infra

GCP infrastructure provisioned in openshift-online/gcp-hcp-infra#872.

Jira: GCP-554

Ref: https://docs.ci.openshift.org/how-tos/adding-a-cluster-profile/

Test plan

  • ci/prow/boskos-config-generation passes
  • ci/prow/check-cluster-profiles-config passes
  • Secret syncs to build clusters (cluster-secrets-platform-gcp in ci namespace)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Adds the gcp-hcp-infra GCP cluster profile, restricted to openshift-online/gcp-hcp-infra, and configures the cluster secret as cluster-secrets-platform-gcp for keyless GCP authentication via Workload Identity Federation (WIF) credential configuration files.
  • Adds the gcp-hcp-infra-quota-slice Boskos quota slice with three concurrent slots (max/min 3) to limit platform E2E test runs.

Register the gcp-hcp-infra cluster profile restricted to
openshift-online/gcp-hcp-infra, and add 3 Boskos quota slots
for concurrency-limiting platform E2E test runs.

Part of GCP-554: dedicated E2E CI infrastructure for gcp-hcp-infra.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jimdaga
jimdaga marked this pull request as draft July 17, 2026 18:41
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Adds a platform-gcp cluster profile for gcp-hcp-infra, provisions three Boskos quota slices, and bootstraps the associated cluster-secrets-platform-gcp secret from pull-secret.

Changes

Platform GCP provisioning

Layer / File(s) Summary
Quota-slice generation and configuration
core-services/prow/02_config/generate-boskos.py, core-services/prow/02_config/_boskos.yaml
Adds platform-gcp-quota-slice with three free leases in the generator configuration and emitted Boskos resources.
Cluster profile and secret bootstrap
ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml, core-services/ci-secret-bootstrap/_config.yaml
Adds the platform-gcp profile for gcp-hcp-infra and creates its cluster secret from registry credentials in pull-secret.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • openshift/release#82035: Adds analogous quota-slice and cluster-secret plumbing for AWS Konflux production clusters.

Suggested labels: lgtm, approved

Suggested reviewers: sosiouxme, psalajova

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only adds config entries and a Boskos generator constant; no Ginkgo test titles were added or changed.
Test Structure And Quality ✅ Passed No Ginkgo test code changed; the PR only updates YAML config and a Python Boskos generator, so this check is not applicable.
Microshift Test Compatibility ✅ Passed This PR only changes CI/Boskos/config YAML and Python generation data; no new Ginkgo tests or MicroShift-sensitive test code is added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: PR only changes CI/Boskos config; no Ginkgo e2e tests or test code were added, so there are no new SNO assumptions to review.
Topology-Aware Scheduling Compatibility ✅ Passed Only cluster-profile, Boskos, and secret-bootstrap config changed; no pod specs, node selectors, affinity, PDBs, or topology settings were added.
Ote Binary Stdout Contract ✅ Passed PR only adds YAML config and a Boskos data entry; the generator’s new code is a CONFIG dict entry and no stdout writes appear in process-level paths.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the PR only changes config (cluster profile, Boskos, secret bootstrap).
No-Weak-Crypto ✅ Passed PASS: the diff only adds cluster/Boskos config entries; no MD5/SHA1/DES/RC4/3DES/ECB, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed Touched files are config-only, and no privileged/root/hostNetwork/allowPrivilegeEscalation settings appear in them.
No-Sensitive-Data-In-Logs ✅ Passed The patch adds config entries only; no new log calls or plaintext secrets/PII are introduced in the touched files.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change set: a new platform-gcp profile, Boskos quota, and secret bootstrap support.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jimdaga

jimdaga commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@jimdaga

jimdaga commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@openshift-ci
openshift-ci Bot requested review from psalajova and sosiouxme July 17, 2026 18:42
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 17, 2026
- Register platform-gcp cluster profile restricted to
  openshift-online/gcp-hcp-infra
- Add platform-gcp-quota-slice (3 slots) to Boskos generator
  and regenerate _boskos.yaml
- Add ci-secret-bootstrap entry for cluster-secrets-platform-gcp
  (pull-secret seeding)

Vault self-service secret already created at
selfservice/gcp-hcp-platform-ci/credentials with WIF credential
config (syncs to cluster-secrets-platform-gcp in ci namespace).

Part of GCP-554: dedicated E2E CI infrastructure for gcp-hcp-infra.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jimdaga
jimdaga force-pushed the feature/GCP-554-cluster-profile-boskos branch from 94735b4 to f57fdc0 Compare July 17, 2026 20:52
@jimdaga jimdaga changed the title Add gcp-hcp-infra cluster profile and Boskos quota slots Add platform-gcp cluster profile, Boskos quota, and secret bootstrap Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jimdaga
Once this PR has been reviewed and has the lgtm label, please assign droslean for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jimdaga

jimdaga commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jimdaga: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@jimdaga: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check-cluster-profiles-config f57fdc0 link false /test check-cluster-profiles-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant