Skip to content

shiftstack/liveliness: skip TLS verify for dev-install CA workaround #83891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 26, 2026
Merged

shiftstack/liveliness: skip TLS verify for dev-install CA workaround #83891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ then
source "${SHARED_DIR}/proxy-conf.sh"
fi

# TODO: Remove once dev-install clouds have Python 3.13+ compatible CA certs (shiftstack/dev-install#238).
yq --yaml-output --in-place ".clouds[\"${OS_CLOUD}\"].verify = false" "${SHARED_DIR}/clouds.yaml"

@mandre mandre Aug 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might actually be better to modify the secrets directly for the impacted clouds, so that we avoid disabling cert validation on all environments.

@IlanZuckerman IlanZuckerman Aug 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandre I might be wrong, but from what i saw, today only liveliness-mecha-central uses this step, so the PR doesn’t touch other clouds. So this temporal WA is narrower until the certs are fixed.

@dlaw4608 dlaw4608 Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandre that is a good point, and @IlanZuckerman you are also correct, at the moment only one test config references the workflow: shiftstack-liveliness step in the release repo. So I think as this is a temporary fix, and as far as I know no other jobs are being configured to use the same workflow: shiftstack-liveliness eg liveliness-hwoffload, we should be good to keep the current workaround as is? WDYT


set +e
echo "DEBUG: Running liveliness check script..."
./server.sh -d -t -l -f ${TESTING_FLAVOR} -i ${TESTING_IMAGE} -e ${OPENSTACK_EXTERNAL_NETWORK} ${AZ_ARG} shiftstack-ci-${CLUSTER_NAME}
Expand Down