Repository navigation
[kustomize_deploy] Bootstrap SKMO leaf admin-two before leaf OSCP apply - #4182
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Deydra71
changed the title
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 51m 47s |
fb3e206 to
4bf208e
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 50s |
4bf208e to
025968b
Compare
025968b to
2bc9873
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 27m 12s |
2bc9873 to
cc62440
Compare
|
The test project with dependencies on this PR openstack-k8s-operators/architecture#827 and openstack-k8s-operators/octavia-operator#688 passed |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 53m 01s |
|
recheck |
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 24s |
|
Hello @Valkyrie00 @evallesp ! Can I please get a review on this PR? Thanks! |
|
/agentic_review |
Code Review by Qodo
1. Dry runs modify central Keystone
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
Hey @Deydra71 👋, I just left a comment on a specific point, I think it's important to take a look at it, and if you could take a look at what qodo found, but overall LGTM. |
After osp-secret password randomization, create admin-two in central Keystone using AdminPassword from the leaf kustomize manifest, before oc apply. Remove the stale prepare-leaf bootstrap that read the static osp-secrets.env template instead of the deployed leaf secret. Add `_leaf_oscp.resources is defined` and `_keystone_lb_svc.resources is defined` Without this check, accessing .resources on the error dict raises an AttributeError, which Ansible treats as a fatal exception (and doesn't retry). Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>
cc62440 to
6a1a8a0
Compare
|
@Valkyrie00 Thanks for the reviews&assistance! I addressed findings #3 and #4. Findings #1 and #2 are not valid. SKMO never runs in geenrate only mode, it's always as full deployment and in one OCP cluster |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 46m 10s |
|
recheck |
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 6h 10m 23s |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brjackma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f6464b6
into
openstack-k8s-operators:main
4 participants
After osp-secret password randomization, create admin-two in central Keystone using AdminPassword from the leaf kustomize manifest, before
oc apply.Remove the stale prepare-leaf bootstrap that reads the static
osp-secrets.envtemplate instead of the deployed leaf secret.Add
_leaf_oscp.resources is definedand_keystone_lb_svc.resources is defined. Without this check, accessing resources on the error dict raises an AttributeError, which Ansible treats as a fatal exception (and doesn't retry).