Skip to content

Fix TLS Memcached port expectation and bump infra/lib-common - #823

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
lmiccini:fix/tls-memcached-port-test
Oct 19, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
lmiccini:fix/tls-memcached-port-test

Conversation

@lmiccini

@lmiccini lmiccini commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Update the TLS functional test to expect Memcached TLS connections on port 11212, matching the updated infra-operator helper and generated keystone.conf.

@lmiccini
lmiccini force-pushed the fix/tls-memcached-port-test branch from a060981 to 7afb0b6 Compare October 19, 2026 09:45
@lmiccini lmiccini changed the title Fix TLS Memcached port expectation Fix TLS Memcached port expectation and bump infra/lib-common Oct 19, 2026

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: edd4edb8-c5f6-46fb-bd7e-20800910b673
📥 Commits

Reviewing files that changed from the base of the PR and between 27c1cd2 and c9cbb02.

⛔ Files ignored due to path filters: 2
  • api/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing: 3
  • api/go.mod
  • go.mod
  • test/functional/keystoneapi_controller_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated functional validation to expect Keystone’s Memcached servers on port 11212. The change is limited to the test expectation and does not alter application behavior.
    • No end-user-facing features or behavior changes are included in this update. The release has no new user workflows or changes to existing product capabilities.

The pull request updates pinned Go module versions and changes the expected Memcached port in a TLS Keystone functional test.

Changes: Dependency and test updates

Layer / File(s) Summary
Dependency versions and TLS test expectation
api/go.mod, go.mod, test/functional/keystoneapi_controller_test.go
The Go module files update dependency versions. The TLS configuration test changes its expected Memcached port from 11211 to 11212.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: stuggi

Merge Risk: ⚪ Minimal · up to c9cbb

The TLS test expectation matches the generated configuration, while non-TLS checks retain port 11211. No material merge-blocking risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the two main changes: the TLS Memcached port expectation and the infra/lib-common version updates.
Description check Passed The description directly explains the TLS functional test update and its alignment with the infra-operator helper and generated keystone.conf.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lmiccini
lmiccini force-pushed the fix/tls-memcached-port-test branch from 7afb0b6 to c9cbb02 Compare October 19, 2026 09:58
@openshift-ci openshift-ci Bot removed the lgtm label Oct 19, 2026

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 19, 2026

@mauricioharley mauricioharley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, mauricioharley, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mauricioharley,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/a96d7020512d44af8494c02f999f720e

✔️ keystone-s2i-content-provider SUCCESS in 1h 50m 38s (non-voting)
✔️ keystone-s2i-test SUCCESS in 1h 35m 59s (non-voting)
✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 57m 15s
✔️ keystone-operator-kuttl SUCCESS in 46m 48s (non-voting)
✔️ keystone-operator-tempest SUCCESS in 1h 18m 16s (non-voting)

@openshift-merge-bot
openshift-merge-bot Bot merged commit be8b225 into openstack-k8s-operators:main Oct 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants