Skip to content

Use inet6-aware memcached_servers for [keystone_authtoken] in nova.conf - #1217

Open
yushoyamaguchi wants to merge 1 commit into
openstack-k8s-operators:mainfrom
yushoyamaguchi:memcachedserver-in-nova_conf
Open

yushoyamaguchi wants to merge 1 commit into
openstack-k8s-operators:mainfrom
yushoyamaguchi:memcachedserver-in-nova_conf

Conversation

@yushoyamaguchi

@yushoyamaguchi yushoyamaguchi commented Sep 23, 2026 •

Copy link
Copy Markdown

fix #1216

[cache]'s non-TLS branch already renders memcache_servers with the inet6: prefix (.MemcachedServersWithInet), required by python-memcached on IPv6 deployments — otherwise it defaults to AF_INET and DNS resolution fails outright. [keystone_authtoken] was still using the plain .MemcachedServers variable, so token cache lookups never connect and every authenticated request falls through to a live Keystone call after ~30s of failed lookups (3 servers × ~2 failed A-record attempts each).

  • templates/nova/nova.conf: switch [keystone_authtoken]'s memcached_servers to .MemcachedServersWithInet, matching [cache].
  • test/functional/nova/novaapi_controller_test.go: update the two assertions that hardcoded the (buggy) prefix-less expected value to call GetMemcachedServerListWithInetString() instead, same as the neighboring [cache] assertions already do.

Replace 'MemcachedServers' with 'MemcachedServersWithInet' in nova.conf for IPv6 usecase.

Signed-off-by: Yusho Yamaguchi <ysh.824@outlook.jp>
@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yushoyamaguchi
Once this PR has been reviewed and has the lgtm label, please assign kk7ds for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Hi @yushoyamaguchi. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 8fe1e8c9-cd26-4fdf-a79f-5e6e534cf543

📥 Commits

Reviewing files that changed from the base of the PR and between 594f860 and 07352f4.

📒 Files selected for processing (2)
  • templates/nova/nova.conf
  • test/functional/nova/novaapi_controller_test.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated Nova’s Memcached server configuration to use the address format expected by the cache service.

Walkthrough

The Nova configuration template now uses MemcachedServersWithInet for memcached_servers. The non-TLS and TLS functional tests derive their expected server lists from the Memcached instance.

Changes

Memcached server configuration

Layer / File(s) Summary
Memcached configuration and assertions
templates/nova/nova.conf, test/functional/nova/novaapi_controller_test.go
The template uses MemcachedServersWithInet for memcached_servers. The non-TLS and TLS tests compare the configured value with the server list returned by the Memcached instance.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: amartyasinha

Merge Risk: ⚪ Minimal · up to 07352

No actionable merge risk is established in the changed configuration or its TLS and non-TLS assertions.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main configuration change and its IPv6 purpose.
Description check ✅ Passed The description directly explains the IPv6 issue, the template change, and the related test updates.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/e8d1df9b71c04cbe93c7bc839a5c187e

✔️ openstack-meta-content-provider SUCCESS in 3h 47m 15s
✔️ nova-operator-kuttl SUCCESS in 49m 47s
✔️ nova-operator-kuttl-placement SUCCESS in 39m 26s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 26m 59s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 45m 02s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[keystone_authtoken] memcached_servers missing inet6: prefix on IPv6-only deployments

1 participant