Skip to content

[18.0-fr7] Drop implied main/master branch matchers pragma - #1219

Open
amartyasinha wants to merge 1 commit into
openstack-k8s-operators:18.0-fr7from
amartyasinha:18.0-fr7-drop-main-master-pragma
Open

amartyasinha wants to merge 1 commit into
openstack-k8s-operators:18.0-fr7from
amartyasinha:18.0-fr7-drop-main-master-pragma

Conversation

@amartyasinha

Copy link
Copy Markdown
Contributor

The pragma section declaring implied-branches: [main, master] was inherited from main when this stable branch was cut (added on main in 3501282 to alias main/master, where the repo default is main but jobs run against master). On a release branch that alias is wrong: it makes this branch's job definitions (e.g. nova-operator-kuttl, which depends on openstack-meta-content-provider) also match main and master changes.

Because of that leak, any main change that moves nova-operator-kuttl off the meta content provider fails to freeze its job graph:

Unable to freeze job graph: Job nova-operator-kuttl depends on
openstack-meta-content-provider which was not run.

Removing the pragma lets Zuul's default per-branch implied matchers scope this branch's config to 18.0-fr7 only (matching how watcher-operator's stable branches, which carry no pragma, behave). No functional change to this branch's own CI.

The pragma section declaring `implied-branches: [main, master]` was
inherited from main when this stable branch was cut (added on main in
3501282 to alias main/master, where the repo default is main but jobs
run against master). On a release branch that alias is wrong: it makes
this branch's job definitions (e.g. nova-operator-kuttl, which depends
on openstack-meta-content-provider) also match main and master changes.

Because of that leak, any main change that moves nova-operator-kuttl off
the meta content provider fails to freeze its job graph:

  Unable to freeze job graph: Job nova-operator-kuttl depends on
  openstack-meta-content-provider which was not run.

Removing the pragma lets Zuul's default per-branch implied matchers scope
this branch's config to 18.0-fr7 only (matching how watcher-operator's
stable branches, which carry no pragma, behave). No functional change to
this branch's own CI.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Amartya Sinha <amsinha@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amartyasinha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 943ce537-60f6-4720-907b-2581656e9e73

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/193b1391872d4a5d8890e24f538519ba

✔️ openstack-meta-content-provider SUCCESS in 3h 13m 46s
❌ nova-operator-kuttl FAILURE in 55m 03s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 14m 06s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 37m 45s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant