-
Notifications
You must be signed in to change notification settings - Fork 89
fix:multiple CodeQL scan issues #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msslulu
wants to merge
81
commits into
opentiny:develop
Choose a base branch
from
msslulu:fix-codeql-scanning
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
c2f63de
fix:codeql scan
msslulu 2a05919
fix:codeql scan
msslulu 1746057
fix:codeql scan
msslulu 03e143f
fix:codeql scan
msslulu b324c37
fix:codeql scan
msslulu ceb3717
fix:codeql scan
msslulu bcb7ee0
Merge pull request #2 from msslulu/code-scanning
msslulu fe1a54c
fix:codeql scan
msslulu 82fdc15
fix:codeql scan
msslulu a09a635
fix:codeql scan
msslulu b1087fc
fix:codeql scan
msslulu c919e36
fix:codeql scan
msslulu 8310dac
Merge pull request #3 from msslulu/code-scanning
msslulu 93ed667
fix:codeql scan
msslulu 2d512ec
Merge pull request #4 from msslulu/code-scanning
msslulu 5673da3
fix:codeql scan
msslulu 06e73eb
Merge pull request #5 from msslulu/code-scanning
msslulu 96457c5
fix:codeql scan
msslulu 0e8a488
Merge pull request #6 from msslulu/code-scanning
msslulu 84d2d55
fix:codeql scan Security issue
msslulu 1870d90
fix:codeql scan Security issue
msslulu 1e654c6
fix:codeql scan Security issue
msslulu 320d46e
fix:codeql scan Security issue
msslulu 9af2034
fix:codeql scan Security issue
msslulu 81b04c8
fix:codeql scan Security issue
msslulu c7c8686
fix:codeql scan Security issue
msslulu cd4ac3d
fix:codeql scan Security issue
msslulu 1573d3e
fix:codeql scan Security issue
msslulu 23f513f
fix:codeql scan Security issue
msslulu 950f477
fix:codeql scan Security issue
msslulu c88bd7b
fix:codeql scan Security issue
msslulu 1717e83
fix:codeql scan Security issue
msslulu 756565e
fix:codeql scan Security issue
msslulu 76c3a0b
fix:codeql scan Security issue
msslulu 0481570
fix:codeql scan Security issue
msslulu 271f0c2
fix:codeql scan Security issue
msslulu 3a8b939
fix:codeql scan Security issue
msslulu f4c04ea
fix:codeql scan Security issue
msslulu 8a87a97
fix:codeql scan Security issue
msslulu 7029e72
fix:codeql scan Security issue
msslulu 39ba7ad
fix:codeql scan Security issue
msslulu b57732c
fix:codeql scan Security issue
msslulu 476d772
fix:codeql scan Security issue
msslulu 381ed9e
fix:codeql scan Security issue
msslulu 6613573
fix:codeql scan Security issue
msslulu 42662e2
fix:codeql scan Security issue
msslulu 74397d5
Merge remote-tracking branch 'origin/fix-codeql-scanning' into fix-co…
msslulu 1171e5b
fix:codeql scan Security issue
msslulu efaf48e
fix:codeql scan Security issue
msslulu b782207
fix:codeql scan Security issue
msslulu d3cea77
fix:codeql scan Security issue
msslulu bc88fa5
fix:codeql scan Security issue
msslulu 99be186
fix:codeql scan Security issue
msslulu 417c270
fix:codeql scan Security issue
msslulu deb53c1
fix:codeql scan Security issue
msslulu 111c981
fix:codeql scan Security issue
msslulu 6f528e8
fix:codeql scan Security issue
msslulu ce799c2
fix:codeql scan Security issue
msslulu a0a7ca4
fix:codeql scan Security issue
msslulu 1e9bb5f
fix:codeql scan Security issue
msslulu cf47cef
fix:codeql scan Security issue
msslulu f66cbb2
fix:codeql scan Security issue
msslulu 8131cf1
fix:codeql scan Security issue
msslulu 7550d7f
fix:codeql scan Security issue
msslulu dd71933
fix:codeql scan Security issue
msslulu 85189cb
fix:codeql scan Security issue
msslulu f1191b6
fix:codeql scan Security issue
msslulu 21a16b7
fix:codeql scan Security issue
msslulu 365f4e7
fix:codeql scan Security issue
msslulu 9e2eb51
fix:codeql scan Security issue
msslulu a427f91
fix:codeql scan Security issue
msslulu b7007cd
fix:codeql scan Security issue
msslulu ee9ba38
fix:codeql scan Security issue
msslulu ece3fb0
fix:codeql scan Security issue
msslulu 1d8f948
fix:codeql scan Security issue
msslulu 9277aaf
fix:codeql scan Security issue
msslulu 83137f3
fix:codeql scan Security issue
msslulu da5607c
fix:codeql scan Security issue
msslulu 30d0ca5
fix:codeql scan Security issue
msslulu cc0cd9c
fix:codeql scan Security issue
msslulu ae62766
fix:codeql scan Security issue
msslulu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| java_build_mode="${1:-autobuild}" | ||
|
|
||
| matrix_entries="" | ||
|
|
||
| has_files() { | ||
| git ls-files "$@" | grep . >/dev/null | ||
| } | ||
|
|
||
| add_entry() { | ||
| local entry="$1" | ||
| if [ -n "$matrix_entries" ]; then | ||
| matrix_entries="$matrix_entries,$entry" | ||
| else | ||
| matrix_entries="$entry" | ||
| fi | ||
| } | ||
|
|
||
| if has_files '.github/workflows/*.yml' '.github/workflows/*.yaml'; then | ||
| add_entry '{"language":"actions","build-mode":"none"}' | ||
| fi | ||
|
|
||
| if has_files '*.java'; then | ||
| add_entry "{\"language\":\"java-kotlin\",\"build-mode\":\"$java_build_mode\"}" | ||
| fi | ||
|
|
||
| if has_files '*.js' '*.jsx' '*.ts' '*.tsx' '*.mjs' '*.cjs' '*.vue' '*.html'; then | ||
| add_entry '{"language":"javascript-typescript","build-mode":"none"}' | ||
| fi | ||
|
|
||
| printf '{"include":[%s]}\n' "$matrix_entries" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,221 @@ | ||
| name: CodeQL Full Scan | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: '34 7 * * 1' | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| packages: read | ||
| actions: read | ||
|
|
||
| jobs: | ||
| detect: | ||
| name: Detect CodeQL languages | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||
| outputs: | ||
| matrix: ${{ steps.matrix.outputs.matrix }} | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Build matrix | ||
| id: matrix | ||
| shell: bash | ||
| run: | | ||
| matrix=$(bash .github/scripts/codeql-matrix.sh manual) | ||
| printf 'matrix=%s\n' "$matrix" >> "$GITHUB_OUTPUT" | ||
|
|
||
| analyze: | ||
| needs: detect | ||
| name: Full scan (${{ matrix.language }}) | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: ${{ fromJSON(needs.detect.outputs.matrix) }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up JDK 17 | ||
| if: matrix.language == 'java-kotlin' | ||
| uses: actions/setup-java@v5 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' | ||
| cache: maven | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v4 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| build-mode: ${{ matrix.build-mode }} | ||
|
|
||
| - name: Build project | ||
| if: matrix.language == 'java-kotlin' | ||
| run: mvn -B clean test-compile -DskipTests -Dcheckstyle.skip=true -Dpmd.skip=true -Dspotbugs.skip=true -Dcpd.skip=true | ||
|
|
||
| - name: Prepare CodeQL SARIF directory | ||
| shell: bash | ||
| run: | | ||
| rm -rf codeql-sarif | ||
| mkdir -p codeql-sarif | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| id: codeql-analysis | ||
| uses: github/codeql-action/analyze@v4 | ||
| with: | ||
| output: ${{ github.workspace }}/codeql-sarif | ||
| upload: always | ||
| category: "/codeql-full:${{ matrix.language }}" | ||
|
|
||
| - name: Summarize CodeQL SARIF report | ||
| id: sarif-summary | ||
| if: always() | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
|
|
||
| mkdir -p codeql-sarif | ||
| report_index="codeql-sarif/scan-files.txt" | ||
| sarif_count=0 | ||
| invalid_sarif=0 | ||
| violations=0 | ||
|
|
||
| { | ||
| printf 'language=%s\n' '${{ matrix.language }}' | ||
| printf 'codeql_output=%s\n' '${{ github.workspace }}/codeql-sarif' | ||
| printf '\nGenerated SARIF files:\n' | ||
| } > "$report_index" | ||
|
|
||
| while IFS= read -r -d '' file; do | ||
| sarif_count=$((sarif_count + 1)) | ||
| result_count=$(jq '[.runs[]?.results[]?] | length' "$file" 2>/dev/null || true) | ||
|
|
||
| if [[ "$result_count" =~ ^[0-9]+$ ]]; then | ||
| violations=$((violations + result_count)) | ||
| printf '%s results=%s\n' "$file" "$result_count" >> "$report_index" | ||
| else | ||
| invalid_sarif=$((invalid_sarif + 1)) | ||
| printf '%s results=invalid-sarif\n' "$file" >> "$report_index" | ||
| fi | ||
| done < <(find codeql-sarif -type f -name '*.sarif' -print0) | ||
|
|
||
| { | ||
| printf '\nSummary:\n' | ||
| printf 'sarif_count=%s\n' "$sarif_count" | ||
| printf 'invalid_sarif=%s\n' "$invalid_sarif" | ||
| printf 'violations=%s\n' "$violations" | ||
| } >> "$report_index" | ||
|
|
||
| printf 'sarif_count=%s\n' "$sarif_count" >> "$GITHUB_OUTPUT" | ||
| printf 'invalid_sarif=%s\n' "$invalid_sarif" >> "$GITHUB_OUTPUT" | ||
| printf 'violations=%s\n' "$violations" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Install SARIF tools | ||
| if: ${{ always() && hashFiles('codeql-sarif/**/*.sarif') != '' }} | ||
| run: python -m pip install sarif-tools | ||
|
|
||
| - name: Generate CodeQL HTML report | ||
| id: html-report | ||
| if: ${{ always() && hashFiles('codeql-sarif/**/*.sarif') != '' }} | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
|
|
||
| html_dir="codeql-html-report" | ||
| rm -rf "$html_dir" | ||
| mkdir -p "$html_dir" | ||
|
|
||
| html_count=0 | ||
| while IFS= read -r -d '' sarif_file; do | ||
| sarif html "$sarif_file" --output "$html_dir" | ||
| html_count=$((html_count + 1)) | ||
| printf '%s -> %s/\n' "$sarif_file" "$html_dir" | ||
| done < <(find codeql-sarif -type f -name '*.sarif' -print0) | ||
|
|
||
| index_file="$html_dir/reports.html" | ||
| { | ||
| printf '<!doctype html>\n' | ||
| printf '<html lang="en">\n' | ||
| printf '<head><meta charset="utf-8"><title>CodeQL HTML Reports</title></head>\n' | ||
| printf '<body>\n' | ||
| printf '<h1>CodeQL HTML Reports - %s</h1>\n' '${{ matrix.language }}' | ||
| printf '<ul>\n' | ||
| while IFS= read -r -d '' html_file; do | ||
| link="${html_file#$html_dir/}" | ||
| printf '<li><a href="%s">%s</a></li>\n' "$link" "$link" | ||
| done < <(find "$html_dir" -maxdepth 1 -type f -name '*.html' ! -name 'reports.html' -print0 | sort -z) | ||
| printf '</ul>\n' | ||
| printf '</body>\n' | ||
| printf '</html>\n' | ||
| } > "$index_file" | ||
|
|
||
| if [ -n "${GITHUB_STEP_SUMMARY:-}" ]; then | ||
| { | ||
| printf '## CodeQL HTML report\n\n' | ||
| printf '| Metric | Result |\n' | ||
| printf '|------|------|\n' | ||
| printf '| Language | %s |\n' '${{ matrix.language }}' | ||
| printf '| HTML files | %s |\n' "$html_count" | ||
| printf '| Artifact | codeql-full-html-%s |\n' '${{ matrix.language }}' | ||
| } >> "$GITHUB_STEP_SUMMARY" | ||
| fi | ||
|
|
||
| printf 'html_count=%s\n' "$html_count" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Upload CodeQL SARIF report | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: codeql-full-sarif-${{ matrix.language }} | ||
| path: codeql-sarif | ||
| if-no-files-found: error | ||
| retention-days: 30 | ||
|
|
||
| - name: Upload CodeQL HTML report | ||
| if: ${{ always() && hashFiles('codeql-html-report/**/*.html') != '' }} | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: codeql-full-html-${{ matrix.language }} | ||
| path: codeql-html-report | ||
| if-no-files-found: error | ||
| retention-days: 30 | ||
|
|
||
| - name: Check CodeQL findings | ||
| if: always() | ||
| shell: bash | ||
| env: | ||
| SARIF_COUNT: ${{ steps.sarif-summary.outputs.sarif_count }} | ||
| INVALID_SARIF: ${{ steps.sarif-summary.outputs.invalid_sarif }} | ||
| VIOLATIONS: ${{ steps.sarif-summary.outputs.violations }} | ||
| run: | | ||
| sarif_count="${SARIF_COUNT:-0}" | ||
| invalid_sarif="${INVALID_SARIF:-0}" | ||
| violations="${VIOLATIONS:-0}" | ||
|
|
||
| if [[ "$sarif_count" -eq 0 ]]; then | ||
| echo "::error::CodeQL did not produce a SARIF report." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "$invalid_sarif" -ne 0 ]]; then | ||
| echo "::error::CodeQL produced $invalid_sarif invalid SARIF report(s)." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "$violations" -ne 0 ]]; then | ||
| echo "::error::CodeQL found $violations result(s)." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "CodeQL found no results." | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codeql-full.yml 中的 Initialize CodeQL 步骤未配置 config-file: ./.github/codeql/codeql-config.yml。与 codeql.yml 相比,缺少了对测试代码及生成目录的路径排除。