Repository navigation
Tests for older dictionary layouts and a clear error for invalid dates - #158
Merged
Merged
Conversation
…dictionary() (#151) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0154SimKVEa4TH9HJ5GELbuv
…d date (#150) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0154SimKVEa4TH9HJ5GELbuv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #151 and #150 (closed; their code was committed to dev without a PR).
Changes
update_dictionary()(update_dictionary() migrates the old dictionary layout without file_name, so update_metadata() runs on older packages #151). Two branches ofmigrate_dictionary_layout()added in 3d46f7c had no test. A new test covers an unnamed first column holding an index with gaps (1, 2, 5, as in the fecalcanuga package), which is still dropped as the index column, and an unnamed column holding text, which stops the run with the error that asks to name or remove the column and leaves the file unchanged.update_description()(update_description() resets Date on every run; keep an existing date, set it on purpose #150). Adatethat is notNULL,"today", aDateor a"YYYY-MM-DD"string naming a real day used to fall through to the baseas.Date()error. It now stops withcli::cli_abort()naming the accepted forms, checked before the DESCRIPTION file is touched. The@param datedocumentation names the string form, a new test covers five invalid values and a valid string, and NEWS.md has a bullet under Fixed.Checks
devtools::test(): 926 passed, 0 failed, 0 warnings, 0 skippeddevtools::check(): 0 errors, 0 warnings, 0 notes