Skip to content

fix: preserve execution state when switching output tabs - #484

Merged
Dunqing merged 1 commit into
mainfrom
fix/preserve-output-tab-state
Nov 15, 2026
Merged

Dunqing merged 1 commit into
mainfrom
fix/preserve-output-tab-state

Conversation

@Dunqing

@Dunqing Dunqing commented Nov 15, 2026

Copy link
Copy Markdown
Member

Switching away from Printed unmounted its execution panel, destroying active runner iframes and losing console state. Keep the Printed tab content mounted while hidden so Run and Compare continue across output tabs and retain their results and expanded/collapsed console state.

Validation:

  • Reproduced the failure before the fix: switching to ESTree AST removed the active iframe.
  • Chrome checks pass for Run across every output tab, Compare preserving both iframes, completion while hidden, retained results and console visibility, Stop, and source edits cancelling stale runs.
  • Formatting, Vue type checking, lint, and production build pass with existing warnings. Monaco service errors observed during browser checks also reproduce on the unchanged baseline.

AI assistance was used for implementation and verification.

Keep Printed tab content mounted while hidden so switching tabs does not destroy sandbox iframes or discard console state.
@Dunqing
Dunqing marked this pull request as ready for review November 15, 2026 15:37
@Dunqing
Dunqing enabled auto-merge (squash) November 15, 2026 15:41
@github-actions

Copy link
Copy Markdown
Contributor

@Dunqing
Dunqing merged commit 350dd21 into main Nov 15, 2026
4 checks passed
@Dunqing
Dunqing deleted the fix/preserve-output-tab-state branch November 15, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant