Repository navigation
build: upgrade Vaadin to 25.3.0-rc1 - #184
Merged
Merged
Conversation
25.3.0-rc1 is where the `theme` attribute starts serializing combined
variants as `primary small` rather than `small primary`, which the
preceding commit's unordered assertTheme handles.
src/main/frontend/index.html already matches the default template
bundled in flow-server 25.3.0-rc2, so no sync is needed and the build
keeps using Vaadin's pre-built default bundle ("a development mode
bundle build is not needed").
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
<vaadin.version>from 25.3.0-beta1 to 25.3.0-rc1, the newest published platform version (2026-09-21).Why it needed #183 first
rc1 changes the order in which Flow serializes combined theme variants into the
themeattribute —addThemeVariants(LUMO_PRIMARY, LUMO_SMALL)rendered assmall primaryon beta1 and renders asprimary smallon rc1. Against the old whole-stringassertTheme, this bump failed one test:#183 made
assertThemeorder-insensitive and is already on master, so this branch is green on top of it.Default bundle
Per #119, a Vaadin bump also needs
src/main/frontend/index.htmlto match the new version's default template, or the build stops using Vaadin's pre-built default bundle and every IT fails. Checked: the committedindex.htmlis byte-identical to the template bundled in flow-server 25.3.0-rc2 (what rc1 resolves to), so no sync is needed, and the build log confirms "a development mode bundle build is not needed".Testing
Full local
mvn verifyon rc1 with the #183 fix applied: 717 tests, 0 failures. Without the fix: 717 tests, 1 failure (the one quoted above).🤖 Generated with Claude Code