Repository navigation
Add linkable exact session metadata filters - #298
Merged
Merged
Conversation
pedapudi
force-pushed
the
feat/harmonograf-297-session-filters
branch
from
August 15, 2026 03:34
9c7365f to
a13a032
Compare
Owner
Author
|
Review complete (as the consumer-side reviewer for pedapudi/zicato#236). The boundary is exactly right: a generic exact-match metadata filter with AND semantics, bounds-validated identically on both ends (16 keys / 128-char keys / 512-char values, fail-closed route parsing), applied before pagination so total_count stays honest, and search extended to metadata values. No tournament or zicato semantics anywhere. Checking in the built console bundle is the pragmatic call for git-subdirectory consumers that cannot run the frontend build. All four CI lanes green. Merging so the consumer can pin a commit reachable from main rather than a PR-branch head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297.
Adds bounded exact metadata predicates to ListSessions, fixes the documented free-text metadata search, and makes those predicates representable in the ordinary session picker's hash route. Existing single-session viewers and deep links are unchanged; there is no persisted collection, multi-session clock, or integration-specific vocabulary.
Privacy boundary: metadata remains server-side and is not projected into SessionSummary.
Verification: