Repository navigation
Fix poll functions on sockets not properly registering the waker. - #2535
Open
davidv1992 wants to merge 1 commit into
Open
davidv1992 wants to merge 1 commit into
davidv1992 wants to merge 1 commit into
Conversation
When poll_x_ready returned ready, but the try_io function failed with a wouldblock error, we would return std::task::Poll::Pending without properly registering the waker. Retrying the operation as a whole in that case is a better way to ensure the waker does get registered.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
- Coverage 79.60% 79.59% -0.02%
==========================================
Files 134 134
Lines 27020 27025 +5
==========================================
+ Hits 21509 21510 +1
- Misses 5511 5515 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When poll_x_ready returned ready, but the try_io function failed with a wouldblock error, we would return std::task::Poll::Pending without properly registering the waker. Retrying the operation as a whole in that case is a better way to ensure the waker does get registered.