Skip to content

Fix incorrect tlv type for the csptp status tlv. - #2537

Open
davidv1992 wants to merge 1 commit into
mainfrom
csptp-status-tlvtype
Open

davidv1992 wants to merge 1 commit into
mainfrom
csptp-status-tlvtype

Conversation

@davidv1992

Copy link
Copy Markdown
Member

This is a fix for a bug in the current draft of the standard, which reserves the range 0xff00-0xffff for csptp, but mistakenly still used 0xf002 for the status tlv, instead of the intended 0xff02.

This is a fix for a bug in the current draft of the standard, which
reserves the range 0xff00-0xffff for csptp, but mistakenly still used
0xf002 for the status tlv, instead of the intended 0xff02.
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.60%. Comparing base (d89fbb3) to head (6057b1d).

Files with missing lines Patch % Lines
statime-wire/src/common/tlv.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files         134      134           
  Lines       27020    27019    -1     
=======================================
  Hits        21509    21509           
+ Misses       5511     5510    -1     
Flag Coverage Δ
test-aarch64-apple-darwin 81.26% <50.00%> (+<0.01%) ⬆️
test-x86_64-unknown-linux-gnu 79.50% <50.00%> (+<0.01%) ⬆️
test-x86_64-unknown-linux-musl 79.65% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix mistake in csptp standard for the tlv number of the status tlv

1 participant