Remove false-positive debug assert hits against normative behavior.

[gavin-dunlap-luminar]

Description

Port::set_recommended_state asserts !default_ds.slave_only in the M1 | M2 arm. The assertion is wrogn and it panics debug builds of any slave-only instance on a conformant network. According to Figure 31 of IEEE 1588-2019, there is a connection from a BMC_MASTER recommendation to LISTENING. A slave-only instance is recommended M1 or M2 whenever it is the best clock in its domain (the only device powered up so far, or with an aged out grandmaster).

Impact

Release builds are unaffected. Debug builds of slave-only instances panic on the first BMCA cycle that finds no better master. This makes slave_only: true unusable unless debug assertions are disabled for the whole crate. Encountered in the wild while utilizing this crate.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.92%. Comparing base (9ce6055) to head (b27f9cf).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   63.70%   63.92%   +0.21%     
==========================================
  Files          62       62              
  Lines        8020     8096      +76     
==========================================
+ Hits         5109     5175      +66     
- Misses       2911     2921      +10     

Flag	Coverage Δ
fuzz	11.30% <ø> (-2.60%)	⬇️
fuzz-message_sound	11.30% <ø> (-2.60%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidv1992]

Thank you for noticing. I need to do a small pass on the CI before merging this, which may take a little while, but this looks good and I will get around to merging it.

[davidv1992]

@gavin-dunlap-luminar Unfortunately your branch will need rebasing on main before I can merge it. Would you be able to do that or give me permissions to do that?