Skip to content

Upgrade Bomb and Auth Flow Refactor - #127

Open
eyingxuan wants to merge 10 commits into
masterfrom
next-11-upgrade
Open

eyingxuan wants to merge 10 commits into
masterfrom
next-11-upgrade

Conversation

@eyingxuan

@eyingxuan eyingxuan commented Aug 18, 2021 •

Copy link
Copy Markdown
Contributor

This PR:

  • Upgrades us to Next 11, React 17, Typescript 4.3 and Eslint 7
  • Refactors authentication flow to make use of getServerSideProps and Redirect support from Next 11

@codecov

codecov Bot commented Aug 18, 2021 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (8a8a630) to head (aa24ed0).
⚠️ Report is 287 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          24       24           
  Lines        1022     1022           
=======================================
  Hits         1010     1010           
  Misses         12       12           
Flag Coverage Δ
backend 98.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eyingxuan eyingxuan changed the title Upgrade to Next 11 and Auth Flow Refactor Upgrade Bomb and Auth Flow Refactor Aug 18, 2021
@eyingxuan

Copy link
Copy Markdown
Contributor Author

Some issues I realized:

  • withAuthComponent might actually not be necessary - we can just accept user props for components with transformed getServerSideProps

>
<a
href="https://airtable.com/shrIZxIjyAE3gOUSg"
rel="noreferrer"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why we added this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this comment - it was a lint warning, and to be honest it should probably be a lint error because it is a security vulnerability. See here for more details: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants