Repository navigation
Conversation
erwanor
self-requested a review
August 7, 2024 01:47
Contributor
|
Sorry for the late feedback on the PR, I was out for a bit. Overall this looks good to me, I plan to give it a proper review by EOW. Thanks for the contribution! |
erwanor
approved these changes
Oct 28, 2025
erwanor
force-pushed
the
s/ics23-hashop-on-proofs
branch
from
January 6, 2026 16:16
9cc2c24 to
8d8519d
Compare
erwanor
self-requested a review
January 6, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proof returned from
get_with_ics23_proofcurrently hasics23::HashOp::Sha256hard-coded, as well as theics23::ProofSpecreturned fromics23_spec.This PR allows a user to define which
HashOpthose structures are populated with:ics23_specto accept aHashOpas argument, and use it to populate the returned spec.get_with_ics23_proofto accept aics23::ProofSpecas argument, and use it to populate the returned proofHashOpfields.