Remove wheel listener during mouse cleanup - #7344
Open
schulerj89 wants to merge 1 commit into
Open
Conversation
schulerj89
marked this pull request as ready for review
July 27, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7340 by removing the canvas
wheellistener with the sameonMouseWheelcallback duringMouseManager.stopListeners. Adds a focused Vitest regression test that confirms the callback is registered, removed, and no longer fires after cleanup.The stale listener was reproduced in current Phaser and 4.1.0. The claimed retention of the destroyed
Gameand broader memory leak could not be reproduced, so this change is limited to the confirmed listener cleanup defect.Testing
npx vitest run tests/input/mouse/MouseManager.test.js --maxWorkers=1npm run build