Skip to content

feat(theme): make default theme configurable - #698

Merged
liangping merged 1 commit into
ping-pub:masterfrom
burnt-labs:feat/configurable-default-theme
Aug 20, 2026
Merged

feat(theme): make default theme configurable#698
liangping merged 1 commit into
ping-pub:masterfrom
burnt-labs:feat/configurable-default-theme

Conversation

@2xburnt

@2xburnt 2xburnt commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add VITE_DEFAULT_THEME so deployments can choose the initial light or dark theme
  • keep a valid saved user preference ahead of the deployment default
  • preserve the existing dark default when the variable is unset or invalid

Why

Deployments should be able to choose the initial color mode without changing application source. User-selected preferences remain persisted and continue to take precedence.

Behavior

A stored light or dark preference is used first. When no valid preference exists, VITE_DEFAULT_THEME=light selects light mode; dark, an unset value, or any invalid value falls back to dark mode.

Checks

  • corepack yarn type-check
  • corepack yarn build-only
  • VITE_DEFAULT_THEME=light corepack yarn build-only
  • git diff --check

Split

Extracted from #697 so that PR remains focused on semantic theme-token styling.

@2xburnt
2xburnt marked this pull request as ready for review August 18, 2026 17:22
@liangping
liangping merged commit 5337c2a into ping-pub:master Aug 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants