Skip to content

GCC: Keep increase path monotonic - #438

Open
uartnet wants to merge 1 commit into
pion:mainfrom
uartnet:gcc-increase-monotonic
Open

GCC: Keep increase path monotonic#438
uartnet wants to merge 1 commit into
pion:mainfrom
uartnet:gcc-increase-monotonic

Conversation

@uartnet

@uartnet uartnet commented Aug 17, 2026

Copy link
Copy Markdown

The steady-state increase branch caps its result at 1.5 times the received rate. When that cap is below the current target, the increase operation can unexpectedly reduce the target even though the controller remains in the increase state. The other increase branch already guards this invariant.

Keep the target unchanged when the computed rate would be lower, and cover the regression with a focused test.

Validated with go test ./... and go test -race ./pkg/gcc.

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.50%. Comparing base (9a8ca49) to head (afb564a).

Files with missing lines Patch % Lines
pkg/gcc/rate_controller.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   80.27%   80.50%   +0.22%     
==========================================
  Files          88       88              
  Lines        4624     4627       +3     
==========================================
+ Hits         3712     3725      +13     
+ Misses        732      720      -12     
- Partials      180      182       +2     
Flag Coverage Δ
go 80.50% <75.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@uartnet
uartnet force-pushed the gcc-increase-monotonic branch from afb564a to eed8e06 Compare August 17, 2026 22:01
@uartnet uartnet changed the title gcc: keep increase path monotonic GCC: Keep increase path monotonic Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant