Repository navigation
ci: check the plugin pins with sync-plugin-version - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #108 and #109, which each added a plugin version-pin check:
scripts/check-plugin-pin.mjsin CI, andscripts/sync-plugin-version.mjs --check, which nothing called. This keeps one.sync-plugin-version.mjsstays, because the Publish workflow already uses it to write the pins. Its--checkmode now also covers prereleases: every plugin pin must be the same stable version, instead of the check being skipped.Pluginjob runsnode scripts/sync-plugin-version.mjs --check.scripts/check-plugin-pin.mjsis removed.I ran
--checkon a copy ofpackage.jsonandplugin/for each case:0.8.0-beta.0, pins on 0.7.10.8.0-beta.0, README drifted to 0.7.00.8.0-beta.0, beta leaked into.mcp.json0.8.0-beta.0, README pin removedSmoke test
Pluginjob's "Check plugin version pin" step printsplugin version matches 0.7.1.