Repository navigation
Tweak comment placement for semicolons - #544
Merged
Merged
Conversation
Follow up to the last PR. When we have both a `preceding` and `following` node and the comment is `EndOfLine`, we need to check if the line consists of all semicolons. If it does, we really want to treat this like an `OwnLine` comment instead, since the semicolons will just disappear. This is important for relative ordering, and also seems to just make more sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to the last PR. When we have both a
precedingandfollowingnode and the comment isEndOfLine, we need to check if the line consists of all semicolons. If it does, we really want to treat this like anOwnLinecomment instead, since the semicolons will just disappear.This is important for relative ordering, and also seems to just make more sense!