Repository navigation
feat: Add a <termshow-player> element for any HTML page - #449
Merged
Merged
Conversation
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 40570219419
# or always the latest build for this PR
great-docs preview --pr 449Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
<termshow-player>element, so Termshow recordings can play on pages not built with Quarto, such as MkDocs, Sphinx, Docusaurus or plain HTML. It reuses the existing player code: its attributes match the shortcode options,srctakes a render directory or a manifest URL, and a manifest can also be embedded inside the element. It also has a small script API modeled on<video>(play(),pause(),seek(),currentTime,duration,paused) and firesready,play,pauseandendedevents.A new
great-docs termshow assets DIRcommand copies the player's script, stylesheet and fonts and prints the HTML to load them. The shortcode keeps working as before, and the PR also fixes an error the player threw when its script loaded in the page's<head>.