Repository navigation
fix: write shadow tags in the configured order - #469
Merged
Merged
Conversation
Write the shadow-tag list in configuration order, dropping duplicates. Previously, set iteration made this list's order depend on string hashes, so repeated builds could produce different tag data.
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 40878460959
# or always the latest build for this PR
great-docs preview --pr 469Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR writes the
tags.shadowlist into the generated tag data in the order the configuration gives it, with duplicates dropped. The list came from a set, so its order followed string hashing and two identical builds could write different_tags.jsonfiles and inline tag data.