Repository navigation
fix: keep wide-layout.js in place on a repeated configuration pass - #474
Merged
Merged
Conversation
A build runs the site configuration pass twice. Each pass previously removed `wide-layout.js` from `include-after-body` and appended it again. The second pass moved the loader to the end and changed the order in which scripts ran on the page. Replace an existing loader at its current position and append a loader only when it is missing. The first pass is unchanged. Disabling wide layout still removes stale entries.
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 40915660867
# or always the latest build for this PR
great-docs preview --pr 474Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps the
wide-layout.jsloader where the first site configuration pass puts it ininclude-after-body. A build runs that pass twice, and each pass removed the loader and appended it again, so on every site with wide layout enabled (the default) the second pass moved it after all the other page scripts. Nothing else in_quarto.ymldiffers between the two passes.