Repository navigation
refactor: read and write _quarto.yml through one module - #482
Merged
Merged
Conversation
About 25 build methods each opened `_quarto.yml` and parsed or dumped its YAML. Route every build read and write through one module: reads with optional website defaults, writes with the generated-file header and translated navbar labels, initial configuration writes, and edits that write only when they succeed. Preserve each call site's behaviour. Call sites that skipped writes still skip them, and those that read a missing file as an empty site still do. Every build's Quarto project is unchanged.
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 41037545040
# or always the latest build for this PR
great-docs preview --pr 482Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves every read and write of the build's
_quarto.ymlout ofGreatDocsand into one module. About 25 methods each opened the file, parsed or dumped the YAML, and called a shared writer for the generated-file header and the translated navbar labels, so every change to how the file is read or written meant finding all of them. The module reads the file, writes it with the header and translated labels, and offers an edit that writes only when the edit succeeds. Builds are unchanged.