Repository navigation
test(examples): Skip the airmass example app - #2586
Merged
Merged
Conversation
On load, airmass resolves object names through CDS Sesame and downloads IERS tables. Sesame is currently timing out, so Shiny never becomes stable within 30s and every playwright-examples shard 1 job fails. CI should not depend on third-party astronomy services.
schloerke
enabled auto-merge (squash)
October 27, 2026 15:31
Collaborator
Author
|
cc @karangattu . Skipping tests for now as CI is constantly failing. Would like to have this back at some point or have a less brittle solution. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been red since 2026-10-22 because ofexamples/airmass. On load, the app resolves its default objects (M1, NGC35, PLX299) withSkyCoord.from_name(), which calls the CDS Sesame service, and astropy downloads IERS tables. Sesame (cds.unistra.frandcdsweb.u-strasbg.fr) is currently timing out. With a 10s timeout per server, the lookups take longer than the 30s the test waits for Shiny to become stable, so everyplaywright-examples (…, 1)job fails, reruns included. Earlier, an IERS download returning HTTP 400 failed the same test through its warning-line check.This PR always skips airmass in
test_examples. That makes the old Windows/timezonefinder and Python 3.9 airmass skips dead code (the package needs Python 3.10+), so they are removed along with the airmass entry in the allowed-errors table.Verified the airmass case is reported as skipped, and
uv run make format check-lint check-types check-pyrightis clean.