Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updatefrom::potato::countWindowHeightReproducer
The test queues an unrelated callback immediately before calling
countWindowHeight.On unmodified stock Potato, the callback runs inside the function because
updateprocesses the complete Tk event queue. With this patch, it remains pending until the
normal event loop resumes.
Results
Tcl/Tk 8.6.18, Windows, upstream baseline
46d18387bd6b156b85176fa588a60991cbba6235:The primary correction is eliminating nested event-loop processing; the microbenchmark
also showed a roughly 90 percent p95 reduction.
Test
Fresh-worktree validation passed:
This change is based directly on stock Potato and has no dependency on split-screen,
packet-debugger, telemetry, or other custom-client code.