Skip to content

Server class in index.d.ts does not match Pretender class #337

Description

@katehedgpeth

The Server class defined in index.d.ts does not seem to match the Pretender class in ./src/pretender.ts that it is supposed to represent. It is missing the handledRequests, passthroughRequests, and unhandledRequests properties. There may be more missing types, as I haven't examined every prop closely.

It seems to me that instead of having a separate type definition file that has to stay in sync with the class, it would be better to export the types from the class directly with rollup.

I have a PR ready to go that implements this fix. I'll post it in a few minutes and reference this issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions