[haraldsteinlechner]

Problem

Ctrl+Z / Ctrl+Y / Ctrl+S were only handled by the main render control's onkeydown. Every dock panel (annotation properties, annotation tree, surfaces, config, …) is its own page (?page=…) with no key listener, so the shortcuts did nothing while the cursor was over a panel.

The shortcut also checked the model's ctrlFlag, which only key events reaching the render control maintain:

• Ctrl pressed outside the 3D view, then Z inside it → nothing.
• Ctrl pressed in the 3D view and released after the cursor left → ctrlFlag stuck; the next plain Z/S acted as Ctrl+Z/S and picking stayed armed.

Change

• pro3dCtrlShortcut(event) (resources/utilities.js) decides client-side: Ctrl/Cmd, no Alt, not repeated, key Z/Y/S, target not a text-entry field (whitelist: contenteditable, textarea, text-like input types), preventDefault. Modifiers come from the event, not ctrlFlag.
• Events.onCtrlShortcut (Utilities.fs): the page-body onkeydown that asks it and sends the key code. Bubbling delivers the key to the body; the target check is needed because a text field's own undo is the browser's default action, not a listener that could stop the event.
• Attached to every page body in Gui.Pages.pageRouting (dock panels, render, instrument, map projection, image inspector, top-level page).
• New ViewerAction.CtrlShortcut handles undo / redo / save. Z/Y/S removed from the KeyDown case — the render control's keydown bubbles to its page body, so keeping both would undo twice.
• Text/number fields keep native Ctrl+Z/Y for their own text; Ctrl+S there does nothing (default prevented, no browser "save page").
• Both render controls release ctrlFlag/shiftFlag on blur. Ctrl+S no longer resets ctrlFlag (Ctrl may still be held).
• Docs: docs/KeyboardShortcuts.md.

Behaviour notes

• Alt+Z no longer undoes (Keyboard.Modifier counted LeftAlt as Ctrl).
• Other keys (F1–F4, Enter/Backspace/Escape, Delete from Delete with del key #848, …) still need the 3D view focused — unchanged.

Testing

• Section 18 — Keyboard Shortcuts: 11/11 pass, five new: CtrlShortcut Z/Y undo/redo with ctrlFlag unset; KeyDown LeftCtrl+Z no longer touches the undo stack; Ctrl+S keeps a held Ctrl armed; KeyUp clears Ctrl+Shift; onCtrlShortcut calls pro3dCtrlShortcut(event) and decodes the key code (totally).
• Agent review: nothing serious; low findings addressed in the second commit. Not addressed (by design / out of scope): Ctrl+Shift+Z still undoes rather than redoes; a focused element whose own keydown handler calls stopPropagation (e.g. a Semantic dropdown) swallows the shortcut; macOS Electron Edit-menu accelerators not checked.
• Playwright tests-ui/tests/keyboard-undo.spec.ts (passes, ~1.2 min, Dimorphos), focus asserted before every press: two Sky lines; Ctrl+Z / Ctrl+Y in the properties panel undo and redo one; Ctrl+Z in the toolbar's number field undoes nothing, outside it on the top-level page Ctrl+Z / Ctrl+Y undo and redo; with the render control focused by hovering, Ctrl+Z undoes exactly one (no double undo through bubbling).
• Final agent review: ready to merge; its low findings (focus assertion in the spec, docs say focused panel rather than cursor, Shift ignored, prefixed JS global) addressed in the last commit.
• Manual (optional, in Aardium): Ctrl+Z in annotation properties (outside a text field), inside a text field (text undo only), over the 3D view (single undo); Ctrl+S from a panel.

🤖 Generated with Claude Code