Skip to content

Support specifying --concurrency Envoy flag#7499

Open
msanft wants to merge 2 commits into
projectcontour:mainfrom
edgelesssys:msanft/concurrency
Open

Support specifying --concurrency Envoy flag#7499
msanft wants to merge 2 commits into
projectcontour:mainfrom
edgelesssys:msanft/concurrency

Conversation

@msanft

@msanft msanft commented Mar 25, 2026

Copy link
Copy Markdown

On machines with high core count, not setting the --concurrency flag of Envoy results in Envoy defaulting to having as many worker threads as HW threads. In low-load scenarios, this creates very high CPU and memory usage unnecessarily. This fixes the issue by adding a concurrency flag and plumbing it through the ContourDeployment CRD.

224-thread machine without the fix:

icn01@dgx-007:~$ ps -o nlwp $(pidof envoy | awk '{print $1}')
NLWP
 456

after the fix (concurrency: 4):

icn01@dgx-007:~$ ps -o nlwp $(pidof envoy | awk '{print $1}')
NLWP
  14

@msanft msanft requested a review from a team as a code owner March 25, 2026 20:35
@msanft msanft requested review from sunjayBhatia and tsaarni and removed request for a team March 25, 2026 20:35
@tsaarni tsaarni added the release-note/small A small change that needs one line of explanation in the release notes. label Mar 25, 2026
msanft added 2 commits March 25, 2026 22:15
@msanft
Support specifying --concurrency Envoy flag
9fa1c9e 
On machines with high core count, not setting the
`--concurrency` flag of Envoy results in Envoy
defaulting to having as many worker threads as HW
threads. In low-load scenarios, this creates very
high CPU and memory usage unnecessarily. This fixes
the issue by adding a concurrency flag and plumbing
it through the `ContourDeployment` CRD.

Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft
chore: codegen
627def9 
Signed-off-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@msanft msanft force-pushed the msanft/concurrency branch from eae69f2 to 627def9 Compare March 25, 2026 21:15
@github-actions

github-actions Bot commented Apr 25, 2026

Copy link
Copy Markdown

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2026
@msanft

msanft commented Apr 25, 2026

Copy link
Copy Markdown
Author

Not stale

@github-actions github-actions Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2026
@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2026
@msanft

msanft commented May 26, 2026

Copy link
Copy Markdown
Author

Not stale

@github-actions github-actions Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2026
@msanft

msanft commented Jun 1, 2026

Copy link
Copy Markdown
Author

Any chance for a review here? cc @tsaarni @sunjayBhatia

@tsaarni

tsaarni commented Jun 3, 2026

Copy link
Copy Markdown
Member

Thank you @msanft for your contribution
Starting with version 1.37.0, Envoy should have automatically adjust its worker threads based on the pod's maximum CPU limits discovered via cgroup. This approach seems more logical to me than separate configuration knob. However, the feature did not work completely as documented. I have created an issue to track this envoyproxy/envoy#45410

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2026
@msanft

msanft commented Jul 4, 2026

Copy link
Copy Markdown
Author

not stale

@tsaarni

tsaarni commented Jul 4, 2026

Copy link
Copy Markdown
Member

There is PR coming on Envoy envoyproxy/envoy#45729

@github-actions github-actions Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers
@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia sunjayBhatia is a code owner automatically assigned from projectcontour/maintainers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

release-note/small A small change that needs one line of explanation in the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msanft @tsaarni