Skip to content

fix(dev): pre-create _data/logs before compose creates it as root #13194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bharathvemula wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(dev): pre-create _data/logs before compose creates it as root #13194

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac49463
fix(dev): pre-create _data/logs before compose creates it as root
bharathvemula Oct 29, 2026
a0570cf
fix(dev): hint non-recursive chown when root-owned _data blocks logs …
bharathvemula Oct 31, 2026
d249b4b
fix(dev): show mkdir error and only hint chown when _data is not user…
bharathvemula Nov 6, 2026
22e3637
fix(dev): scope _data chown hint to the repository root
bharathvemula Nov 6, 2026
75ce73d
fix(dev): shell-escape the _data path in the chown hint
bharathvemula Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions scripts/development/dev-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,27 @@ require_uv() {
}

services_up() {
# Create _data/logs before Docker runs: on first launch, compose
# bind-mounts create ./_data as root, after which this user can no
# longer mkdir _data/logs and `make dev` fails (see #13082).
# Creating it first keeps it user-owned; the later mkdir in all_run
# stays as an idempotent safety net.
# Anyone who already ran the broken version has a root-owned _data,
# so this mkdir fails: say how to fix it instead of leaving the bare
# "Permission denied". The chown is deliberately non-recursive, since
# _data/postgres and _data/neo4j need to keep their container owners.
# Keep mkdir's own error visible: a full or read-only filesystem fails
# here too, and the chown hint would not fix that. Only suggest the
# chown when _data exists and is not owned by the current user.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
if ! mkdir -p "$REPO_ROOT/_data/logs"; then
if [ -e "$REPO_ROOT/_data" ] && [ ! -O "$REPO_ROOT/_data" ]; then
# Show the absolute path shell-escaped so the command stays safe
# to copy-paste even when the repo path holds spaces or shell
# metacharacters.
warn "_data is owned by root (created by Docker). Run: sudo chown \"${USER:-$(id -un)}\" $(printf '%q' "$REPO_ROOT/_data")"
fi
exit 1
fi
log "Starting postgres + valkey + neo4j via Docker (waits for healthchecks)..."
"${COMPOSE[@]}" -f "$COMPOSE_FILE" up -d --wait postgres valkey neo4j
ok "Services ready: pg:${POSTGRES_PORT} / valkey:${VALKEY_PORT} / neo4j:${NEO4J_PORT} / neo4j-http:${NEO4J_HTTP_PORT}"
Expand Down